Skip to content

datasets_download try/catching the git-lfs prune for versions that do not support -f #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackkolb wants to merge 4 commits into
base: main
Choose a base branch
from
Open

datasets_download try/catching the git-lfs prune for versions that do not support -f #2375

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3ad87e
try/catching the git-lfs prune for versions that do not support -f
jackkolb Apr 28, 2024
8760f3f
Split a comment onto two lines for black
jackkolb Apr 28, 2024
c729e72
Fixed for eslint
jackkolb Apr 28, 2024
875ee0b
Wrapped exception string in str() for better python version compatabi…
jackkolb Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src_python/habitat_sim/utils/datasets_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,15 @@ def clone_repo_source(

# prune the repo to reduce wasted memory consumption
prune_command = "git lfs prune -f --recent"
subprocess.check_call(shlex.split(prune_command), cwd=version_dir)
try:
subprocess.check_call(shlex.split(prune_command), cwd=version_dir)
except subprocess.CalledProcessError as e:
# a response of status code 127 suggests a git-lfs version
# that does not support the -f flag
if "status 127" in str(e):
subprocess.check_call(
shlex.split("git lfs prune --recent"), cwd=version_dir
)


def checkout_repo_tag(repo: Repo, version_dir: str, tag: str):
Expand Down