Skip to content

Add stubs to python bindings to provide typing information.#2415

Closed
0mdc wants to merge 3 commits intomainfrom
0mdc/bindings_typing
Closed

Add stubs to python bindings to provide typing information.#2415
0mdc wants to merge 3 commits intomainfrom
0mdc/bindings_typing

Conversation

@0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 25, 2024

Motivation and Context

This changeset adds stubs to python bindings to provide typing information.
Stub generation depends on pybind11-stubgen.

typing-2024-06-16_22.01.01.mp4

How to test:

  • pip install pybind11-stubgen.
  • Build habitat-sim normally.
  • Import the package in another project, and explore types in your IDE.

WIP:

  • Stubs contain some errors, but they mostly work.
  • CI is not yet handled.
  • Ideally, creating a stub package would scale better, but I could not make it work with bindings. See PEP 561.

How Has This Been Tested

Tested by importing habitat_sim in an external Python file.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from aclegg3, jturner65 and mosra June 25, 2024 19:07
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 25, 2024
@0mdc 0mdc force-pushed the 0mdc/bindings_typing branch from 181e7cd to 060dde3 Compare July 16, 2024 19:20
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see slack thread here

@0mdc 0mdc force-pushed the 0mdc/bindings_typing branch from 5504972 to c70299f Compare January 19, 2025 17:11
@0mdc 0mdc marked this pull request as ready for review January 21, 2025 17:43
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Excited to have this, thanks!

@0mdc 0mdc requested a review from jturner65 January 21, 2025 18:29
@jturner65
Copy link
Contributor

Eventually it would be good to separate the binding process so that all the enums and classes are instantiated in appropriate order and then all their method bindings are added. This will address circular refs between class methods, where each class has a method argument referencing the other class.

@mosra
Copy link
Contributor

mosra commented Jan 22, 2025

That I'm (partially) handling in the m.css stub output already (#2477) -- there it's the types first and functions after. Doesn't handle type dependencies yet but internally it has knowledge about their dependencies so it could attempt to either sort them or make "forward declarations" when dependencies are cyclic (i.e., stringified annotations).

@meta-cla
Copy link

meta-cla bot commented Oct 22, 2025

Hi @0mdc!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@0mdc 0mdc closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants