Skip to content

[BE] - remove Observation returns from simulator.py step and reset#2499

Open
aclegg3 wants to merge 5 commits into
mainfrom
alex-11_12-simulator_py_refactor
Open

[BE] - remove Observation returns from simulator.py step and reset#2499
aclegg3 wants to merge 5 commits into
mainfrom
alex-11_12-simulator_py_refactor

Conversation

@aclegg3

@aclegg3 aclegg3 commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Motivation and Context

Refactors the simulator.py API to:

  • remove Observation return from step and reset. These are "environemt" API decisions. In general, stepping and resetting the world would not trigger any sensor collection or return.
  • removes the automated and forced disabling of rendering/textures when Sensors are not pre-declared. Configuration should not be assuming what the user wants and forcing itself. Provides freedom to declare sensors after initialization.
  • removes some deprecated and unused functions
  • adds some additional docstrings to clarify the initialization, resetting, and wrapping done in python over the binding API

How Has This Been Tested

CI should pass for sim.
Will fail for habitat-lab until refactored in-line with new reset and step API expectations.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 13, 2024
@meta-cla

meta-cla Bot commented May 19, 2026

Copy link
Copy Markdown

Hi @aclegg3!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants