Skip to content

Opt-in support for multisampled color rendering#2555

Open
mosra wants to merge 2 commits into
mainfrom
color-multisample
Open

Opt-in support for multisampled color rendering#2555
mosra wants to merge 2 commits into
mainfrom
color-multisample

Conversation

@mosra

@mosra mosra commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

As requested by @eundersander on Slack. By enabling simConfig.multisample (exposed to both C++ and Python) all sensors that are just color-only will produce a 8x multisampled output to avoid aliasing.

How Has This Been Tested

There's a new test verifying the output with this flag enabled.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 17, 2025
@mosra

mosra commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

Note: the failing test is due to the lighting setup being somehow different in my working copy, resulting in an image that's uniformly brighter in the parts affected by lighting. I suspect it's caused by something that isn't tracked by Git (some config file different? some scene/stage/whatever file missing, and defaults being picked instead?), and I just couldn't figure out what it was.

To fix that, run the failing test locally with -XS$(pwd) and replace the file it generated.

@jturner65

Copy link
Copy Markdown
Contributor

Note: the failing test is due to the lighting setup being somehow different in my working copy, resulting in an image that's uniformly brighter in the parts affected by lighting. I suspect it's caused by something that isn't tracked by Git (some config file different? some scene/stage/whatever file missing, and defaults being picked instead?), and I just couldn't figure out what it was.

To fix that, run the failing test locally with -XS$(pwd) and replace the file it generated.

I'll investigate this when I can. If need be I can regenerate the test image.

Comment on lines +117 to +118
* sensors. Can be only enabled if @ref createRenderer is enabled, mutually
* exclusive with @ref enableHBAO.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosra how big is the ask to make this feature compatible with HBAO? I think the primary value add here is improved optics use cases. That typically means HBAO would be desired as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, yeah -- was basically just waiting for feedback whether you want such feature or not.

I looked into making it work with HBAO initially, but then scrapped that because I wasn't sure if that still counts as a quick MVP that Eric was after :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants