Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in support for multisampled color rendering #2555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mosra
Copy link
Collaborator

@mosra mosra commented Mar 17, 2025

Motivation and Context

As requested by @eundersander on Slack. By enabling simConfig.multisample (exposed to both C++ and Python) all sensors that are just color-only will produce a 8x multisampled output to avoid aliasing.

How Has This Been Tested

There's a new test verifying the output with this flag enabled.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 17, 2025
@mosra
Copy link
Collaborator Author

mosra commented Mar 19, 2025

Note: the failing test is due to the lighting setup being somehow different in my working copy, resulting in an image that's uniformly brighter in the parts affected by lighting. I suspect it's caused by something that isn't tracked by Git (some config file different? some scene/stage/whatever file missing, and defaults being picked instead?), and I just couldn't figure out what it was.

To fix that, run the failing test locally with -XS$(pwd) and replace the file it generated.

@jturner65
Copy link
Collaborator

Note: the failing test is due to the lighting setup being somehow different in my working copy, resulting in an image that's uniformly brighter in the parts affected by lighting. I suspect it's caused by something that isn't tracked by Git (some config file different? some scene/stage/whatever file missing, and defaults being picked instead?), and I just couldn't figure out what it was.

To fix that, run the failing test locally with -XS$(pwd) and replace the file it generated.

I'll investigate this when I can. If need be I can regenerate the test image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants