Skip to content

add translation and rotation offsets to RenderAssetCreationInfo#2574

Open
aclegg3 wants to merge 2 commits into
mainfrom
alex_05-13_render_instance_offsets
Open

add translation and rotation offsets to RenderAssetCreationInfo#2574
aclegg3 wants to merge 2 commits into
mainfrom
alex_05-13_render_instance_offsets

Conversation

@aclegg3

@aclegg3 aclegg3 commented May 13, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Previously when creating RenderAssetInstances we've assumed the top level transformation (object's state pose) is enough and that other local transformations will be encapsulated within the asset or the owning superstructure (e.g. the articulated rig). However, when using RenderReplay in HitL with isaac integration we run replay at the link level rather than the visual shape level. Since URDF visual shapes can support their own local transformation frame () we were missing a few local transformations leading to a mismatch between the Isaac internal simulation state and the render state seen in the client.
This change introduces an additional level of configurable local transformations to the render instance pipeline allowing these per-visual element offsets to be properly captured. In general this change allows local transformation offsets to be defined and tracked by RenderReplay.

How Has This Been Tested

Tested locally in HitL.
TODO: unit tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…low for handling of URDF visuals with their own origin transforms
@aclegg3
aclegg3 requested review from 0mdc and eundersander May 13, 2025 20:03
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 13, 2025
@meta-cla

meta-cla Bot commented May 19, 2026

Copy link
Copy Markdown

Hi @aclegg3!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants