{Build} Core - Bump VRS pin for XPRS NVDEC symbols (#383) - #383
Closed
YLouWashU wants to merge 1 commit into
Closed
Conversation
Contributor
|
@YLouWashU has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114445000. |
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 1, 2026 02:23
a8da262 to
dc127f8
Compare
meta-codesync
Bot
changed the title
YLouWashU
added a commit
to YLouWashU/projectaria_tools
that referenced
this pull request
Aug 3, 2026
) Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `2f4fc9e555311928bc4643ea251a1542216f5e74`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. The cibuildwheel jobs on the child diffs exercise the resulting wheel. Differential Revision: D114445000
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 3, 2026 19:54
dc127f8 to
6358fef
Compare
YLouWashU
added a commit
to YLouWashU/projectaria_tools
that referenced
this pull request
Aug 3, 2026
) Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `2f4fc9e555311928bc4643ea251a1542216f5e74`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. The cibuildwheel jobs on the child diffs exercise the resulting wheel. Differential Revision: D114445000
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 3, 2026 19:56
6358fef to
fc4c772
Compare
YLouWashU
added a commit
to YLouWashU/projectaria_tools
that referenced
this pull request
Aug 3, 2026
) Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `2f4fc9e555311928bc4643ea251a1542216f5e74`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. The cibuildwheel jobs on the child diffs exercise the resulting wheel. Differential Revision: D114445000
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 3, 2026 20:19
fc4c772 to
226c7d9
Compare
YLouWashU
added a commit
to YLouWashU/projectaria_tools
that referenced
this pull request
Aug 3, 2026
) Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `2f4fc9e555311928bc4643ea251a1542216f5e74`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. The cibuildwheel jobs on the child diffs exercise the resulting wheel. Differential Revision: D114445000
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 3, 2026 20:37
226c7d9 to
02b8340
Compare
) Summary: Explanation: `projectaria_tools` builds VRS via `FetchContent` with a pinned `GIT_TAG` in `cmake/Setup3rdParty.cmake`. The previous pin (`125db715`, main Jun 26, 2026) predates the XPRS NVDEC changes, so `core/python/XprsPyBind.h` references `xprs::hasCudaSupport` while the fetched VRS does not declare it. The external wheel build fails with: ``` core/python/XprsPyBind.h:152:14: error: no member named 'hasCudaSupport' in namespace 'xprs' &xprs::hasCudaSupport, ``` This bumps the VRS pin to `2f4fc9e555311928bc4643ea251a1542216f5e74`, which carries the NVDEC symbols (`xprs::hasCudaSupport` plus the `ENABLE_NVCODEC` plumbing), unblocking NVDEC in the wheel build. Reproducibility: The pinned commit resolves in `facebookresearch/vrs`, so `FetchContent` can fetch it and the wheel build can compile `XprsPyBind.h`. The cibuildwheel jobs on the child diffs exercise the resulting wheel. Reviewed By: kongchen1992 Differential Revision: D114445000
YLouWashU
force-pushed
the
export-D114445000
branch
from
August 3, 2026 23:02
02b8340 to
16d186c
Compare
Contributor
|
This pull request has been merged in 756d341. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Explanation:
projectaria_toolsbuilds VRS viaFetchContentwith a pinnedGIT_TAGincmake/Setup3rdParty.cmake. The previous pin (125db715, main Jun 26, 2026)predates the XPRS NVDEC changes, so
core/python/XprsPyBind.hreferencesxprs::hasCudaSupportwhile the fetched VRS does not declare it. The externalwheel build fails with:
This bumps the VRS pin to
2f4fc9e555311928bc4643ea251a1542216f5e74, whichcarries the NVDEC symbols (
xprs::hasCudaSupportplus theENABLE_NVCODECplumbing), unblocking NVDEC in the wheel build.
Reproducibility:
The pinned commit resolves in
facebookresearch/vrs, soFetchContentcanfetch it and the wheel build can compile
XprsPyBind.h. The cibuildwheel jobson the child diffs exercise the resulting wheel.
Reviewed By: kongchen1992
Differential Revision: D114445000