{BugFix} Core - Wire NeuralBand calibration libs into OSS CMake build - #384
Open
YLouWashU wants to merge 1 commit into
Open
{BugFix} Core - Wire NeuralBand calibration libs into OSS CMake build#384YLouWashU wants to merge 1 commit into
YLouWashU wants to merge 1 commit into
Conversation
Summary: Explanation: D114276637 added `NeuralBandEmgCalibration`, `NeuralBandImuCalibration`, and the `NeuralBandBatchCalibration` wrapper under `core/calibration/` and consumed them from `NeuralBandBatchPlayer.cpp`, but only wired the new sources through BUCK. The OSS CMake build was never updated, so the GitHub Actions `build-and-test.yml` and `test-for-build-wheels.yml` workflows fail at link time with 4 undefined references (`NeuralBandEmgCalibration::fromParamsJson`, `NeuralBandImuCalibration::fromParamsJson`, `NeuralBandImuCalibration::getAccelScalingFactor`, `NeuralBandImuCalibration::getGyroScalingFactor`) coming from `libplayers.a(NeuralBandBatchPlayer.cpp.o)`. This mirrors the BUCK targets in CMake: - `core/calibration/CMakeLists.txt`: add `neural_band_emg_calibration` and `neural_band_imu_calibration` libraries (matching the BUCK `oxx_static_library` targets), add `NeuralBandBatchCalibration.h` to `sensor_calibration`'s header list, and link both new libs from `sensor_calibration` `PUBLIC` (so downstream users of `SensorCalibration.h` get the wrapper header + symbols). - `core/data_provider/players/CMakeLists.txt`: link `neural_band_emg_calibration` and `neural_band_imu_calibration` from `players` `PUBLIC`, matching the `public_deps` on the players BUCK target. Reproducibility: GitHub Actions `build-and-test.yml` and `test-for-build-wheels.yml` will pass on the next ShipIt export. Local BUCK build is unaffected. ___ Differential Revision: D114627185
Contributor
|
@YLouWashU has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114627185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Explanation:
D114276637 added
NeuralBandEmgCalibration,NeuralBandImuCalibration,and the
NeuralBandBatchCalibrationwrapper undercore/calibration/and consumed them from
NeuralBandBatchPlayer.cpp, but only wired thenew sources through BUCK. The OSS CMake build was never updated, so the
GitHub Actions
build-and-test.ymlandtest-for-build-wheels.ymlworkflows fail at link time with 4 undefined references
(
NeuralBandEmgCalibration::fromParamsJson,NeuralBandImuCalibration::fromParamsJson,NeuralBandImuCalibration::getAccelScalingFactor,NeuralBandImuCalibration::getGyroScalingFactor) coming fromlibplayers.a(NeuralBandBatchPlayer.cpp.o).This mirrors the BUCK targets in CMake:
core/calibration/CMakeLists.txt: addneural_band_emg_calibrationand
neural_band_imu_calibrationlibraries (matching the BUCKoxx_static_librarytargets), addNeuralBandBatchCalibration.htosensor_calibration's header list, and link both new libs fromsensor_calibrationPUBLIC(so downstream users ofSensorCalibration.hget the wrapper header + symbols).core/data_provider/players/CMakeLists.txt: linkneural_band_emg_calibrationandneural_band_imu_calibrationfromplayersPUBLIC, matching thepublic_depson the players BUCKtarget.
Reproducibility:
GitHub Actions
build-and-test.ymlandtest-for-build-wheels.ymlwill pass on the next ShipIt export. Local BUCK build is unaffected.
Differential Revision: D114627185