fix(DataCollection): close filter chip #1665
Merged
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
siguenzaraul
force-pushed
the
data-collection-filter-chip-close
branch
from
034cebb to
cd563b7
Compare
sergiocarracedo
approved these changes
Apr 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where closing a filter chip didn't refresh the data collection. The removeFilterValue function was passing the old filter state to onChange instead of the updated state. Now properly creates and passes a new filter object that excludes the removed filter, ensuring data refreshes correctly when removing filters.
Screenshots (if applicable)
before:
Grabacion.de.pantalla.2025-04-23.a.las.17.13.11.mov
after:
Grabacion.de.pantalla.2025-04-23.a.las.17.13.40.mov
Type of Change