Move topology changing messages to Scheduler and introduce Zombie list #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsergio
force-pushed
the
sergio/graph_messages
branch
5 times, most recently
from
6bd9801 to
815fae2
Compare
iamsergio
changed the title
iamsergio
force-pushed
the
sergio/graph_messages
branch
2 times, most recently
from
7e7dfe6 to
8a17ad2
Compare
iamsergio
force-pushed
the
sergio/graph_messages
branch
from
8a17ad2 to
09ff0db
Compare
iamsergio
force-pushed
the
sergio/graph_messages
branch
from
09ff0db to
559ac97
Compare
For fair-acc/opendigitizer#246. OD will need to be adapted to send messages to scheduler instead of graph. Adapted tests. Introduced qa_SchedulerMessages.cpp for topology changing messages. Signed-off-by: Sergio Martins <[email protected]>
This allows to remove blocks without having to stop the scheduler. Running blocks can't transition directly to stopped state, so we move them into a "zombie list". There's a maintenance period where we delete blocks that have stopped. Furthermore, deleted blocks are now removed from each thread's local block list. Signed-off-by: Sergio Martins <[email protected]>
This was never used. It was set but never read and the job list was never updated. With the "zombie list" there's no need for it anymore. Signed-off-by: Sergio Martins <[email protected]>
Signed-off-by: Sergio Martins <[email protected]>
iamsergio
force-pushed
the
sergio/graph_messages
branch
3 times, most recently
from
bd30775 to
ad530b9
Compare
During the maintenance period, when we cleanup zombies, we also check if a thread should adopt blocks that were added meanwhile Signed-off-by: Sergio Martins <[email protected]>
Lifecycle doesn't support it, so besides being a no-op it also spammed the logs with errors. The only permitted transition is the user resuming the scheduler, which should put it in initialized state Signed-off-by: Sergio Martins <[email protected]>
We move all the existing blocks to the zombie list. They'll get deleted when stopped. The scheduler needs to be restarted, so its init() method runs again to construct the job list and threads. The message is being processed by a worker thread, therefore we can't restart the scheduler here as that would crash. Scheduler is restarted automatically by OD when it receives the message reply. Also, the scheduler didn't support being restarted at all, the reset() method implementation was missing. Signed-off-by: Sergio Martins <[email protected]>
iamsergio
force-pushed
the
sergio/graph_messages
branch
from
ad530b9 to
5d06c75
Compare
As that's where all message based scheduler tests are Signed-off-by: Sergio Martins <[email protected]>
|
ivan-cukic
approved these changes
May 31, 2025
| @@ -6,7 +6,7 @@ | |||
| #include <mutex> | |||
| #include <queue> | |||
| #include <set> | |||
| #include <source_location> | |||
|
|
|||
There was a problem hiding this comment.
Nitpick - remove empty line
| @@ -667,18 +667,84 @@ class SchedulerBase : public Block<Derived> { | |||
| _zombieBlocks.push_back(std::move(block)); | |||
| } | |||
|
|
|||
| // Moves all blocks into the zombie list | |||
| // Useful for bulk operations such as "set grc yaml" message | |||
| void makeAllZombies() { | |||
There was a problem hiding this comment.
I might be overly accustomed to make being used to make new values make_shared/make_optional/make_pair. Maybe moveAllBlocksToZombieList would be more fitting.
RalphSteinhagen
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move topology changing messages to Scheduler
For fair-acc/opendigitizer#246.
OD will need to be adapted to send messages to scheduler instead of graph.
Adapted tests.
Introduced qa_SchedulerMessages.cpp for topology changing messages.
Introduce zombie list for stopping blocks
This allows to remove blocks without having to stop the scheduler.
Running blocks can't transition directly to stopped state, so we
move them into a "zombie list". There's a maintenance period where
we delete blocks that have stopped.
Furthermore, deleted blocks are now removed from each thread's
local block list.