Skip to content

Replace <object> tags with <iframe> tags#361

Merged
ethanjli merged 2 commits into
masterfrom
fix/firefox-embeds
Jan 27, 2024
Merged

Replace <object> tags with <iframe> tags#361
ethanjli merged 2 commits into
masterfrom
fix/firefox-embeds

Conversation

@ethanjli
Copy link
Copy Markdown
Collaborator

@ethanjli ethanjli commented Jan 27, 2024

This PR fixes #354 by replacing <object> tags with <iframe> tags in the Node-RED dashboard - for both the file browser as reported in #354 and the new Grafana monitoring dashboard on the System Monitoring page (which was introduced by PR #346).

@ethanjli ethanjli enabled auto-merge January 27, 2024 17:47
@ethanjli ethanjli added this pull request to the merge queue Jan 27, 2024
Merged via the queue into master with commit 8214208 Jan 27, 2024
@ethanjli ethanjli deleted the fix/firefox-embeds branch January 27, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend/node-red-dashboard: Embedded pages are broken on Firefox

1 participant