Export the filtered volume metadata field on all sample types#364
Merged
Conversation
Collaborator
Author
|
I tested this PR with an image acquisition using the "Plankton net" sample type and then ran the segmenter on the resulting dataset and confirmed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #316 by making the Node-RED dashboard export the
sample_total_volumemetadata field (corresponding to the "Filtered volume" input field on the "Sample" page) for all sample types, instead of only exporting it on horizontal Plankton tow sample types.This PR also (hopefully) fixes a regression caused by #352, in which the segmenter would be unable to create a
done.txtfile within/home/pi/data/imgbecause that directory would be automatically created with root ownership.