Skip to content

Add Agibot D1#111

Merged
fan-ziqi merged 2 commits into
fan-ziqi:mainfrom
lovelyyoshino:main
Mar 20, 2026
Merged

Add Agibot D1#111
fan-ziqi merged 2 commits into
fan-ziqi:mainfrom
lovelyyoshino:main

Conversation

@lovelyyoshino

Copy link
Copy Markdown
Contributor

Description

This update aims to add functionality for Zhiyuan D1 and resolve the issue where G1 fails to start. After analysis, it was found that the startup failure of G1 was due to improper parameter settings in the configuration file. By adjusting the relevant parameters, the issue has been successfully resolved, allowing G1 to start smoothly.

The motivation behind this change is to enhance system stability and user experience, ensuring that users do not encounter startup obstacles when using G1. Additionally, the addition of Zhiyuan D1 functionality will provide users with more operational options and flexibility.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have run the pre-commit checks with pre-commit run --all-files
  • My changes generate no new warnings
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@fan-ziqi fan-ziqi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外,pre-commit检查没有通过

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除这个文件

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改了之后会影响beyondmimic效果,能否不改?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个目前看下来主要问题是这个导致的

# "right_elbow_pitch_joint", # 25 R_ELBOW
# "right_elbow_roll_joint", # 26 R_WRIST_ROLL
# ]
# 29个控制关节(与URDF中的实际名称匹配)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除这一行

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# ]
# 29个控制关节(与URDF中的实际名称匹配)
joint_names = [
# 腿部关节 (12个)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全部改为英文注释

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数写成与原来名称一样的函数,只不过添加一个参数move_down_threshold,默认值为原来函数的0.5,在你需要使用0.1的时候在cfg里改,不要写成两个函数,有点冗余

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件改动没用的话都删掉吧

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件没有更改

@lovelyyoshino lovelyyoshino changed the title Add Zhiyuan D1 functionality and fix G1 startup issue Add Agibot D1 functionality and fix G1 startup issue Dec 23, 2025
@fan-ziqi

fan-ziqi commented Mar 20, 2026

Copy link
Copy Markdown
Owner

没啥其他的问题了,这个PR就提交D1吧,G1先删掉吧,等可以再拆出来PR
机器人的图添加一个env,然后把机器人拖进去调整一下位置视角就可以了
image
记得给你自己加入contributor md

@lovelyyoshino lovelyyoshino changed the title Add Agibot D1 functionality and fix G1 startup issue Add Agibot D1 functionality issue Mar 20, 2026
@fan-ziqi fan-ziqi changed the title Add Agibot D1 functionality issue Add Agibot D1 Mar 20, 2026
@fan-ziqi
fan-ziqi merged commit 09f7fb4 into fan-ziqi:main Mar 20, 2026
1 check passed
fabeha-raheel pushed a commit to fabeha-raheel/robot_lab that referenced this pull request May 11, 2026
Co-authored-by: mpl9725440@163.com <mpl9725440@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants