chore(deps): Update the FastPFOR C++ library to v0.3.1#62
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FastPFOR C++ library submodule from version 0.3.0 to 0.3.1 to resolve a macOS build failure caused by a duplicate target name issue in the simde.cmake file. The update also adds macOS testing to the CI workflow to prevent similar platform-specific issues in the future.
Changes:
- Updated the FastPFOR C++ library submodule to v0.3.1 (commit aa1a6c36)
- Added macOS testing job to the CI workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cpp | Updated FastPFOR submodule commit hash to v0.3.1 |
| .github/workflows/ci.yml | Added test-macos job and updated ci-passed dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yutannihilation
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nyurik
force-pushed
the
chore/update-cpp-v0.3.1
branch
from
February 25, 2026 17:33
e88f3d4 to
acf7809
Compare
nyurik
added a commit
that referenced
this pull request
Feb 25, 2026
…alled yet (#63) (In order to fix build on aarch64 platfroms, #62 is still needed in addition to this change) I was wondering why [the FastPFOR-rs repository](https://github.com/fast-pack/FastPFOR) tests macOS runner without installing SIMDe; FastPFOR fetches and build SIMDe automatically. However, it seems the include path and define are not configured correctly when with `cxx_build::bridge()`. So, this pull request attempts to fix it by manually doing the equivalent to this part of `cmake_modules/simde.cmake`. ```cmake target_include_directories(simde INTERFACE "${simde_SOURCE_DIR}") # Enables native aliases. Not ideal but makes it easier to convert old code. target_compile_definitions(simde INTERFACE SIMDE_ENABLE_NATIVE_ALIASES) ``` --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
CommanderStorm
added a commit
to maplibre/maplibre-tile-spec
that referenced
this pull request
Feb 25, 2026
I believe fast-pack/FastPFOR-rs#62 and fast-pack/FastPFOR-rs#63 fixed the compilation problem on aarch64 platforms. Now that FastPFOR is updated to v0.7, I think we can enable build on Arm Linux and Arm macOS again (At least, I have no difficulty to build this on my macOS). (But, I don't know what issues "Currently, seems flaky" comment refers to, so it's possible I miss some problems...) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Frank Elsinga <frank@elsinga.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the build fails on macOS with this error. It seems something is wrong with this version of FastPFOR's
cmake_modules/simde.cmake. Fortunately, it seems it's fixed in the latest release. So, this pull request updates the C++ library.(Honestly, I'm not sure what problem this is and why this works now. The only change on the file was that specifying the commit hash of simde's repository (fast-pack/FastPFOR@f7771da))