Protect active sessions from empty cleanup#5633
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
Skip automatic empty-session cleanup for active and finalizing recordings, matching the existing running-batch protection.
ComputelessComputer
force-pushed
the
fix/protect-active-session-cleanup
branch
from
ccc696b to
9cfe205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip automatic empty-session cleanup for active and finalizing recordings, matching the existing running-batch protection.
Note
Medium Risk
Changes when empty sessions are deleted on tab close, which affects recording lifecycle; the change only adds skip conditions and aligns with existing batch protection.
Overview
Closing a session tab no longer triggers automatic empty-session cleanup when that session is in
activeorfinalizingmode, in addition to the existingrunning_batchguard increateSessionTabCloseHandler.The close handler still only deletes empty sessions after invalidating resources when the session is inactive and empty; live or in-progress recordings are left alone when their tab is closed.
Tests now assert that cleanup is skipped for all three non-inactive modes in a loop, not only
running_batch.Reviewed by Cursor Bugbot for commit 9cfe205. Bugbot is set up for automated code reviews on this repo. Configure here.