feat: add post-quantum ML-DSA-44 signer, verifier and varsig algorithm#37
Draft
Peeja wants to merge 1 commit into
Draft
feat: add post-quantum ML-DSA-44 signer, verifier and varsig algorithm#37Peeja wants to merge 1 commit into
Peeja wants to merge 1 commit into
Conversation
Ports the unmerged PR #32 (ML-DSA-44 post-quantum signatures, by Alan Shaw) onto the post-#30 `multikey` layout. PR #32 was built on the old `principal/*` package layout and the old varsig API. PR #30 then merged and restructured `principal/*` into `multikey/*` and reworked `varsig/` (the old API now lives under `varsig/prev`), leaving #32 stale. This reimplements the same feature — reusing Alan's reviewed crypto logic and deterministic signing via `filippo.io/mldsa` — against the current layout: - `multikey/mldsa44` — the signer, mirroring `multikey/secp256k1` and `multikey/ed25519` (Generate/GenerateIssuer/Parse/Format/Decode/Encode/ FromRaw + the `multikey.Signer` methods). Private-key multicodec 0x131a. - `multikey/mldsa44/verifier` — the verifier, self-registering its Decoder with the multikey registry via `init`. Public-key multicodec 0x1210. - `varsig/algorithm/mldsa` — the ML-DSA-44 varsig algorithm. ML-DSA is neither ECDSA nor EdDSA, so like `nonstandard` it is a single-segment, self-registering algorithm package exposing `MLDSA44` (paralleling `eddsa.Ed25519` / `ecdsa.Secp256k1`). Varsig discriminant 0x1210, preserved from #32 so wire encoding stays compatible. Multicodec and varsig code values are unchanged from #32, so `did:key` encodings and signatures interoperate. Tests cover generate/sign/verify, encode/decode and did:key round-trips. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV
Peeja
pushed a commit
to fil-forge/bench-http-header-ucan-size
that referenced
this pull request
Jul 2, 2026
The earlier attested-signatures migration had to drop the mldsa44 (post-quantum ML-DSA-44) key branch because that key type did not exist on ucantone main after the principal/* -> multikey/* refactor. It has now been reinstated on the new layout in fil-forge/ucantone#37, so this restores the mldsa44 case using multikey/mldsa44.GenerateIssuer() and re-pins ucantone at that commit. Because ucantone#37 is not yet merged, this points at that unmerged commit (the new multikey/mldsa44 branch) rather than the old unmerged principal/mldsa44 commit it referenced before. Re-pin to a merged ucantone once #37 lands. See fil-forge/ucantone#30 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV
alanshaw
approved these changes
Jul 2, 2026
alanshaw
left a comment
alanshaw
left a comment
Member
There was a problem hiding this comment.
Thanks I have been meaning to do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the post-quantum ML-DSA-44 (FIPS 204) signer, verifier, and varsig algorithm onto the current
multikeylayout.Why this supersedes #32
This is the same feature as #32 (by @alanshaw), but #32 was written against the pre-#30
principal/*layout and never merged. PR #30 ("Attested Signatures + UCAN Principal Clarification") then restructuredprincipal/*→multikey/*and reworkedvarsig/, leaving #32 stale/conflicting onmain. This PR reimplements #32's reviewed logic in the new layout so it can land. Closes/supersedes #32.What's here
multikey/mldsa44/{signer,signer_test}.goandmultikey/mldsa44/verifier/{verifier,verifier_test}.go— mirrorsmultikey/{ed25519,secp256k1}exactly.GenerateIssuer() (multikey.Issuer, error)matches the sibling constructors; the verifier package self-registers viamultikey.Register(Code, Decode)ininit().varsig/algorithm/mldsa/{mldsa,mldsa_test}.go— ML-DSA as its own self-registering single-segment algorithm (modeled onvarsig/algorithm/nonstandard, since ML-DSA has no curve/hash sub-codes like ECDSA/EdDSA do). Exported asmldsa.MLDSA44, parallelingeddsa.Ed25519/ecdsa.Secp256k1. This leaves the spec-definedvarsig/algorithms.goregistry untouched.go.mod/go.sum— addsfilippo.io/mldsa v0.0.0-20260215214346-43d0283efc3e(the exact version feat: add post-quantum ML-DSA-44 signer, verifier and varsig algorithm #32 used; a stdlib-copy pending Go 1.27's ML-DSA).Wire compatibility
All code values are preserved from #32, so
did:keyand varsig encodings are unchanged:0x131a(mldsa44-priv), public-key multicodec0x1210(mldsa44-pub), varsig algorithm discriminant0x1210. (Spelled asmulticodec.Code(0x…)sincego-multicodechas no ML-DSA constants yet.)Signing is deterministic (
SignDeterministic), matching #32 and the other signers. Tests cover generate→sign→verify anddid:key→multikey.Parse→ verify round-trips, plus a determinism assertion.Verified:
GOWORK=off go build ./... && go vet ./... && go test ./...— all green (multikey/mldsa44,multikey/mldsa44/verifier,varsig/algorithm/mldsaallok).Opened as a draft for review.
🤖 Generated with Claude Code
https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV
Generated by Claude Code