Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1 similar comment
|
|
|
|
| If you're releasing beta/alpha code, be sure to replace the latest version in NPM like so: | ||
|
|
||
| ``` | ||
| npm dist-tag add @finos/fdc3@2.1.1 latest |
There was a problem hiding this comment.
Project maintainers will not be able to run npm dist-tag due to not having permissions on the NPM project, so it might be worth inserting a note here about contact help@finos.org or yourself to sort that out...
Its that of we detect that there is something after the last digit of the version number in the workflow itself and have it set an alternative tag when it runs npm publish, e.g. npm publish --tag prerelease. We can probably figure out a regex to extract 'beta' from 2.2.0-beta.1 automatically...
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Could do with a changelog entries:
- Setup package publishing for mono-repo packages
- Standardized prettier config for fdc3-workbench with other packages)
- 2.2.0-beta.1 pre-release
Left an earlier comment on the (NPM!) release docs. Could perhaps reference the /website/README.md for documentation release
Co-authored-by: Kris West <kris.west@interop.io>
|
|
done |
Did you push? Not seeing the Changelog in this PR anywhere |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
@robmoffat I adjusted your changelog entries slightly - otherwise this LGTM. You might need to approve yourself or ask another maintainer to as I'm now the last push on this PR
|
|
Co-authored-by: Kris West <kris.west@interop.io>
|
I've added a comment about needing support from help@finos for the last step. I have a feeling it should be possible to set the tag in package.json publishConfig but I couldn't find good instructions on how to do this.. especially not in a monorepo. |
|
|
1 similar comment
|
|
|
|
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
LGTM - thanks for getting this working again!
I had said we'd need to do a beta.2 with the readmes for the modules that are missing them... maybe we do if we want to link to them in the email announcing a 2.2 adoption vote - we will need a PR to add those... I guess all you need to do is run through the release commands you documented to also create a release as part of that PR.
2 participants
Testing GitHub actions around releases.
resolves #1514