Skip to content
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/base-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches:
- main
- fdc3-for-web-impl

jobs:
test_and_upload_coverage:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@ jobs:

- name: Publish
if: steps.check-version.outputs.exists == '0'
run: npm publish --provenance --access public
run: npm publish --provenance --access public --workspaces
env:
NODE_AUTH_TOKEN: ${{ secrets[matrix.token-name] }}
58 changes: 45 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,51 @@ From the root package, you can run `npm run build` to build all the modules, or

For installation and usage instructions, see: <https://fdc3.finos.org/docs/supported-platforms#usage>

### Bumping Version Numbers (for maintainers)

It's important that all of the versions of the submodules stay on the same version, and that the references between them are consistent to that version. To change the version number (say before or after a release) run the following:

```
// first, update version number in package.json
npm login
npm version <new version from package.json> --workspaces // changes the version number in all submodule package.json files
npm run syncpack // sycnhronizes version numbers
npm up // fixes node_module references
npm run build // builds all the modules against the new version
npm publish --access=public --workspaces // this step performs a manual release of the npm modules (not needed with GitHub actions releases)
```
### Releasing FDC3 (for maintainers)

This is a 4-step process:

1. **Create a release branch**

Do this locally. Ensure the branch is named `release/v2.0` (or whatever the next version is).

```bash
git checkout -b release/v2.0
```

2. **Update the version numbers in the package.json files**

It's important that all of the versions of the submodules stay on the same version, and that the references between them are consistent to that version. To change the version number (say before or after a release) run the following:

```bash
// first, update version number in package.json
npm login
npm version <new version from package.json> --workspaces // changes the version number in all submodule package.json files
npm run syncpack // sycnhronizes version numbers
npm up // fixes node_module references
npm run build // builds all the modules against the new version
```

3. **Push the branch to publish the packages to npm**

```bash
git push origin release/v2.0
```

This should trigger a GitHub action that will publish the packages to npm.

4. **Create a PR for merging the release branch.**

Once the packages are published, create a PR to merge the release branch into the main branch. You will need other FDC3 maintainers to review and approve the PR.

5. **Set The NPM Version If Releasing A Beta**

If you're releasing beta/alpha code, be sure to replace the latest version in NPM like so:

```
npm dist-tag add @finos/fdc3@2.1.1 latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project maintainers will not be able to run npm dist-tag due to not having permissions on the NPM project, so it might be worth inserting a note here about contact help@finos.org or yourself to sort that out...

Its that of we detect that there is something after the last digit of the version number in the workflow itself and have it set an alternative tag when it runs npm publish, e.g. npm publish --tag prerelease. We can probably figure out a regex to extract 'beta' from 2.2.0-beta.1 automatically...

```


## Getting Involved

Expand Down
Loading
Loading