Skip to content

Context clearing (1197)#1642

Merged
kriswest merged 30 commits intomainfrom
1197-context-clearing
Sep 10, 2025
Merged

Context clearing (1197)#1642
kriswest merged 30 commits intomainfrom
1197-context-clearing

Conversation

@kemerava
Copy link
Contributor

@kemerava kemerava commented Jul 29, 2025

Describe your change

Adding context cleaning

Related Issue

#1379

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?
  • API changes: Does this PR include changes to any of the FDC3 APIs (DesktopAgent, Channel, PrivateChannel, Listener, Bridging)?
    • Docs & Sources: If yes, were both documentation (/docs) and sources updated?

      JSDoc comments on interfaces and types should be matched to the main documentation in /docs
    • Conformance tests: If yes, are conformance test definitions (/toolbox/fdc3-conformance) still correct and complete?

      Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
    • Schemas: If yes, were changes applied to the Bridging and FDC3 for Web protocol schemas?

      The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
      • If yes, was code generation (npm run build) run and the results checked in?

        Generated code will be found at /src/api/BrowserTypes.ts and/or /src/bridging/BridgingTypes.ts
  • Context types: Were new Context type schemas created or modified in this PR?
    • Were the field type conventions adhered to?
    • Was the BaseContext schema applied via allOf (as it is in existing types)?
    • Was a title and description provided for all properties defined in the schema?
    • Was at least one example provided?
    • Was code generation (npm run build) run and the results checked in?

      Generated code will be found at /src/context/ContextTypes.ts
  • Intents: Were new Intents created in this PR?

kemerava and others added 25 commits September 27, 2024 14:19
Co-authored-by: Kris West <kris.west@interop.io>
Co-authored-by: Kris West <kris.west@interop.io>
Co-authored-by: Kris West <kris.west@interop.io>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Context Clearing
Merging to the new branch, will create another PR from that into main
@kemerava kemerava requested a review from a team as a code owner July 29, 2025 12:49
@netlify
Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 9ed5cc0
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/68b05ca0c36c190008eda173
😎 Deploy Preview https://deploy-preview-1642.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - why won't the merge button unlock?

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ???

kriswest
kriswest previously approved these changes Sep 10, 2025
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again ???

hughtroeger
hughtroeger previously approved these changes Sep 10, 2025
bingenito
bingenito previously approved these changes Sep 10, 2025
@kemerava kemerava dismissed stale reviews from bingenito, kriswest, and hughtroeger September 10, 2025 13:20

The merge-base changed after approval.

bingenito
bingenito previously approved these changes Sep 10, 2025
hughtroeger
hughtroeger previously approved these changes Sep 10, 2025
@kemerava kemerava dismissed stale reviews from hughtroeger and bingenito September 10, 2025 13:37

The merge-base changed after approval.

@kriswest kriswest closed this Sep 10, 2025
@kriswest kriswest reopened this Sep 10, 2025
@kriswest kriswest self-requested a review September 10, 2025 13:38
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve!

@kriswest kriswest merged commit 905d651 into main Sep 10, 2025
13 checks passed
@kriswest kriswest deleted the 1197-context-clearing branch September 10, 2025 13:39
@github-actions
Copy link

506 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants