Skip to content

#1702 add invisible flag to table definition#1703

Merged
tanjjj merged 4 commits intofinos:mainfrom
tanjjj:add-invisible-flag-to-table
Sep 5, 2025
Merged

#1702 add invisible flag to table definition#1703
tanjjj merged 4 commits intofinos:mainfrom
tanjjj:add-invisible-flag-to-table

Conversation

@tanjjj
Copy link
Copy Markdown
Contributor

@tanjjj tanjjj commented Sep 2, 2025

Add invisible flag to table definition
Reject creating VP if table is invisible
Start using dedicated reject message

Note only supporting invisible flag for standard non-join table for now. I had a battle with JoinTableDef but because joins: JoinTo* is varargs I coulnd't find an easy way to add invisible flag to join table def without changing all lines calling it.

closes #1702

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 2, 2025

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit ff6b75b
🔍 Latest deploy log https://app.netlify.com/projects/papaya-valkyrie-395400/deploys/68b9fe1c893efa00087b4f2f

@tanjjj tanjjj changed the title #1702 add invisible flag to table definition and reject creating VP i… #1702 add invisible flag to table definition Sep 2, 2025
Copy link
Copy Markdown
Contributor

@heswell heswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@tanjjj tanjjj merged commit 856b524 into finos:main Sep 5, 2025
11 of 12 checks passed
@tanjjj tanjjj deleted the add-invisible-flag-to-table branch September 5, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support invisible tables

2 participants