Skip to content

#1702 add invisible flag to table definition #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanjjj merged 4 commits into from
Sep 5, 2025
Merged

#1702 add invisible flag to table definition #1703

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5306ec
#1702 add invisible flag to table definition and reject creating VP i…
tanjjj Sep 2, 2025
8d68ca4
#1702 use CreateViewPortReject instead of generic message
tanjjj Sep 2, 2025
7fff4f2
#1702 use CreateViewPortReject instead of generic message
tanjjj Sep 2, 2025
ff6b75b
#1702 add tests
tanjjj Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vuu/src/main/scala/org/finos/vuu/api/TableDef.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ class TableDef(val name: String,
val joinFields: Seq[String],
val autosubscribe: Boolean = false,
val links: VisualLinks = VisualLinks(),
val indices: Indices) extends VuuInMemPluginLocator {
val indices: Indices,
val invisible: Boolean = false) extends VuuInMemPluginLocator {

private val createdTimeColumn: SimpleColumn = SimpleColumn(CreatedTimeColumnName, customColumns.length, DataType.fromString("long"))
private val updatedTimeColumn: SimpleColumn = SimpleColumn(LastUpdatedTimeColumnName, customColumns.length + 1, DataType.fromString("long"))
Expand Down
6 changes: 3 additions & 3 deletions vuu/src/main/scala/org/finos/vuu/core/CoreServerApiHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,9 @@ class CoreServerApiHandler(val viewPortContainer: ViewPortContainer,

val table = tableContainer.getTable(msg.table.table)

if (table == null)
errorMsg(s"no table found for ${msg.table}")(ctx)
else {
if (table == null || table.getTableDef.invisible) {
vsMsg(CreateViewPortReject(msg.table, s"no table found for ${msg.table}"))(ctx)
} else {

val columns = if (msg.columns.length == 1 && msg.columns(0) == "*") {
logger.trace("[CreateViewPortRequest] Wildcard specified for columns, going to return all")
Expand Down
Loading