Throttle CRF to two concurrent deploys#10173
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a temporary strategy to manage the concurrency of Cloud Run function deployments. It introduces a dedicated executor with a strict concurrency limit of two for these specific operations, aiming to mitigate issues related to low zip deploy capacity. This change refactors the internal deployment mechanism by providing a specialized executor for Cloud Run function-related tasks. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a dedicated runFunctionExecutor to manage operations for Cloud Run functions, including creation, updates, and deletions, by modifying the Fabricator class and its instantiation. The changes aim to separate the execution logic for Cloud Run functions from general function operations. Review feedback suggests two main improvements: first, ensuring that the runThrottlerOptions in src/deploy/functions/release/index.ts inherit retry and backoff settings from throttlerOptions for consistent and robust behavior, and second, refactoring the identical runFunctionExecutor and functionExecutor configurations in src/commands/functions-delete.ts to a shared constant to improve maintainability and reduce code duplication.
e62f2d7 to
6b20a23
Compare
This reverts commit 0999f31.
To manage concurrency limit of zip deploys temporarily