Skip to content

Throttle CRF to two concurrent deploys#10173

Merged
inlined merged 5 commits intomainfrom
inlined.crf-deploy-concurrency
Mar 25, 2026
Merged

Throttle CRF to two concurrent deploys#10173
inlined merged 5 commits intomainfrom
inlined.crf-deploy-concurrency

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Mar 25, 2026

To manage concurrency limit of zip deploys temporarily

@inlined inlined requested a review from brittanycho March 25, 2026 16:04
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary strategy to manage the concurrency of Cloud Run function deployments. It introduces a dedicated executor with a strict concurrency limit of two for these specific operations, aiming to mitigate issues related to low zip deploy capacity. This change refactors the internal deployment mechanism by providing a specialized executor for Cloud Run function-related tasks.

Highlights

  • Dedicated Executor for Cloud Run Functions: A new runFunctionExecutor has been introduced to specifically manage operations related to Cloud Run functions (creation, updates, and deletions), separating them from general executor tasks.
  • Temporary Concurrency Throttling: The runFunctionExecutor is temporarily configured with a concurrency limit of 2 for Cloud Run function deployment operations. This measure aims to manage the concurrency limit of zip deploys due to low capacity.
  • Fabricator Class Updates: The FabricatorArgs interface and the Fabricator class have been updated to incorporate and utilize the new runFunctionExecutor.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a dedicated runFunctionExecutor to manage operations for Cloud Run functions, including creation, updates, and deletions, by modifying the Fabricator class and its instantiation. The changes aim to separate the execution logic for Cloud Run functions from general function operations. Review feedback suggests two main improvements: first, ensuring that the runThrottlerOptions in src/deploy/functions/release/index.ts inherit retry and backoff settings from throttlerOptions for consistent and robust behavior, and second, refactoring the identical runFunctionExecutor and functionExecutor configurations in src/commands/functions-delete.ts to a shared constant to improve maintainability and reduce code duplication.

Comment thread src/deploy/functions/release/index.ts
Comment thread src/commands/functions-delete.ts Outdated
@inlined inlined force-pushed the inlined.crf-deploy-concurrency branch from e62f2d7 to 6b20a23 Compare March 25, 2026 16:16
@inlined inlined merged commit 0999f31 into main Mar 25, 2026
47 checks passed
@inlined inlined deleted the inlined.crf-deploy-concurrency branch March 25, 2026 18:05
asperpharma added a commit to asperpharma/firebase-tools that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants