Fix CI test failures from Bun.spawn in vitest

[firecow]

• Replace Bun.spawn with child_process.execFile in gcl-env-variable-split tests
• Bun global is unavailable when vitest runs in Node.js worker threads
• Also includes typecheck fix: cast yparser.getOptions() which lacks type definitions

Fixes test and typecheck failures introduced by #1778.

---

Summary by cubic

Fix CI test failures by replacing Bun.spawn with child_process.execFile in the gcl-env-variable-split integration tests, since Bun isn’t available under vitest Node worker threads. Also adds a small type fix for yparser.getOptions().

• Bug Fixes
  • Introduced a runCli helper using execFile to invoke bun src/index.ts with env vars.
  • Preserves stdout and exit code behavior; tests now pass in CI and Node-only environments.
  • Casts yparser.getOptions() to address missing type definitions.

^{Written for commit cd5f5e3. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/test-cases/gcl-env-variable-split/integration.test.ts">

<violation number="1" location="tests/test-cases/gcl-env-variable-split/integration.test.ts:196">
P2: `runCli` can incorrectly report `exitCode: 0` when `execFile` fails with a non-numeric error code. Treat non-exit errors as failures instead of coercing them to success.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: runCli can incorrectly report exitCode: 0 when execFile fails with a non-numeric error code. Treat non-exit errors as failures instead of coercing them to success.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At tests/test-cases/gcl-env-variable-split/integration.test.ts, line 196:

<comment>`runCli` can incorrectly report `exitCode: 0` when `execFile` fails with a non-numeric error code. Treat non-exit errors as failures instead of coercing them to success.</comment>

<file context>
@@ -186,63 +187,32 @@ test("GCL_VARIABLE env split reaches handler as separate variables", async () =>
+            env: {...process.env, ...envVars},
+        }, (error, stdout) => {
+            if (error && error.code === undefined) return reject(error);
+            resolve({stdout, exitCode: typeof error?.code === "number" ? error.code : 0});
+        });
+    });
</file context>

Suggested change

	resolve({stdout, exitCode: typeof error?.code === "number" ? error.code : 0});
	});
	if (error) {
	if (typeof error.code === "number") {
	return resolve({stdout, exitCode: error.code});
	}
	return reject(error);
	}
	resolve({stdout, exitCode: 0});

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud