Skip to content

Fix CI test failures from Bun.spawn in vitest #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firecow merged 1 commit into from
Apr 3, 2026
Merged

Fix CI test failures from Bun.spawn in vitest #1821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 15 additions & 45 deletions tests/test-cases/gcl-env-variable-split/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {splitSemicolonEnvVars} from "../../../src/argv.js";
import chalk from "chalk-template";
import {initSpawnSpy} from "../../mocks/utils.mock.js";
import {WhenStatics} from "../../mocks/when-statics.js";
import {execFile} from "child_process";

beforeAll(() => {
initSpawnSpy(WhenStatics.all);
Expand Down Expand Up @@ -186,63 +187,32 @@ test("GCL_VARIABLE env split reaches handler as separate variables", async () =>

// --- Integration test: spawns real CLI with GCL_VARIABLE env ---

test("GCL_VARIABLE env var is split by CLI middleware", async () => {
const proc = Bun.spawn(
["bun", "src/index.ts", "test-job", "--cwd", "tests/test-cases/gcl-env-variable-split"],
{
env: {
...process.env,
GCL_VARIABLE: "VAR1=from_env1;VAR2=from_env2",
},
stdout: "pipe",
stderr: "pipe",
},
);

const stdout = await new Response(proc.stdout).text();
const exitCode = await proc.exited;
function runCli (envVars: Record<string, string>): Promise<{stdout: string; exitCode: number}> {
return new Promise((resolve, reject) => {
execFile("bun", ["src/index.ts", "test-job", "--cwd", "tests/test-cases/gcl-env-variable-split"], {
env: {...process.env, ...envVars},
}, (error, stdout) => {
if (error && error.code === undefined) return reject(error);
resolve({stdout, exitCode: typeof error?.code === "number" ? error.code : 0});
});
Comment on lines +196 to +197

@cubic-dev-ai cubic-dev-ai Bot Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: runCli can incorrectly report exitCode: 0 when execFile fails with a non-numeric error code. Treat non-exit errors as failures instead of coercing them to success.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At tests/test-cases/gcl-env-variable-split/integration.test.ts, line 196:

<comment>`runCli` can incorrectly report `exitCode: 0` when `execFile` fails with a non-numeric error code. Treat non-exit errors as failures instead of coercing them to success.</comment>

<file context>
@@ -186,63 +187,32 @@ test("GCL_VARIABLE env split reaches handler as separate variables", async () =>
+            env: {...process.env, ...envVars},
+        }, (error, stdout) => {
+            if (error && error.code === undefined) return reject(error);
+            resolve({stdout, exitCode: typeof error?.code === "number" ? error.code : 0});
+        });
+    });
</file context>
Suggested change
resolve({stdout, exitCode: typeof error?.code === "number" ? error.code : 0});
});
if (error) {
if (typeof error.code === "number") {
return resolve({stdout, exitCode: error.code});
}
return reject(error);
}
resolve({stdout, exitCode: 0});
Fix with Cubic

});
}

test("GCL_VARIABLE env var is split by CLI middleware", async () => {
const {stdout, exitCode} = await runCli({GCL_VARIABLE: "VAR1=from_env1;VAR2=from_env2"});
expect(exitCode).toBe(0);
expect(stdout).toContain("from_env1");
expect(stdout).toContain("from_env2");
}, 30_000);

test("GCL_VARIABLE with single value (no semicolon) works via CLI", async () => {
const proc = Bun.spawn(
["bun", "src/index.ts", "test-job", "--cwd", "tests/test-cases/gcl-env-variable-split"],
{
env: {
...process.env,
GCL_VARIABLE: "VAR1=single_value",
},
stdout: "pipe",
stderr: "pipe",
},
);

const stdout = await new Response(proc.stdout).text();
const exitCode = await proc.exited;

const {stdout, exitCode} = await runCli({GCL_VARIABLE: "VAR1=single_value"});
expect(exitCode).toBe(0);
expect(stdout).toContain("single_value");
}, 30_000);

test("GCL_VARIABLE with three semicolon-separated values via CLI", async () => {
const proc = Bun.spawn(
["bun", "src/index.ts", "test-job", "--cwd", "tests/test-cases/gcl-env-variable-split"],
{
env: {
...process.env,
GCL_VARIABLE: "VAR1=first;VAR2=second;VAR3=third",
},
stdout: "pipe",
stderr: "pipe",
},
);

const stdout = await new Response(proc.stdout).text();
const exitCode = await proc.exited;

const {stdout, exitCode} = await runCli({GCL_VARIABLE: "VAR1=first;VAR2=second;VAR3=third"});
expect(exitCode).toBe(0);
expect(stdout).toContain("first");
expect(stdout).toContain("second");
Expand Down
Loading