Artifacts "when" conditions support - #1885
Open
anprowh wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
firecow
reviewed
Jun 22, 2026
| private async copyArtifactsOut (writeStreams: WriteStreams, expanded: {[key: string]: string}) { | ||
| // TODO: update the condition to support when:on_success / when:on_failure | ||
| if (this.jobStatus !== "success" && this.artifacts?.when !== "always") return; | ||
| if (this.jobStatus !== "success" && this.artifacts?.when === "on_success") return; |
Owner
There was a problem hiding this comment.
regression: absent when = on_success in gitlab, so a failed job now uploads. need when ?? on_success + treat warning as failure.
Owner
|
Add some tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix copyArtifactsOut condition to support different
artifacts.whenfield values.Summary by cubic
Update
copyArtifactsOutto honorartifacts.whenvalues (on_success,on_failure,never) so artifacts are exported only when the job status matches the setting. Defaults/alwayscontinue to export as before.Written for commit a165501. Summary will update on new commits.