Skip to content

Artifacts "when" conditions support #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anprowh wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

Artifacts "when" conditions support #1885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,8 +1408,9 @@ If you know what you're doing and would like to suppress this warning, use one o
}

private async copyArtifactsOut (writeStreams: WriteStreams, expanded: {[key: string]: string}) {
// TODO: update the condition to support when:on_success / when:on_failure
if (this.jobStatus !== "success" && this.artifacts?.when !== "always") return;
if (this.jobStatus !== "success" && this.artifacts?.when === "on_success") return;

@firecow firecow Jun 22, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression: absent when = on_success in gitlab, so a failed job now uploads. need when ?? on_success + treat warning as failure.

if (this.jobStatus !== "failed" && this.artifacts?.when === "on_failure") return;
if (this.artifacts?.when === "never") return;
if (!this.artifacts) return;
if ((this.artifacts.paths?.length ?? 0) === 0 && this.artifacts.reports?.dotenv == null) return;

Expand Down