Snapshot Loader 2.0 #4885
Closed
Snapshot Loader 2.0 #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
force-pushed
the
ripatel/snapshot-tiles
branch
from
fd600ba to
10a9577
Compare
mmcgee-jump
reviewed
Apr 28, 2025
mmcgee-jump
reviewed
Apr 28, 2025
| if( FD_UNLIKELY( tile->out_cnt!=1UL ) ) FD_LOG_ERR(( "tile `" NAME "` has %lu outs, expected 1", tile->out_cnt )); | ||
|
|
||
| ctx->fd = open( tile->filerd.file_path, O_RDONLY|O_CLOEXEC ); | ||
| if( FD_UNLIKELY( ctx->fd<0 ) ) FD_LOG_ERR(( "open() failed (%i-%s)", errno, fd_io_strerror( errno ) )); |
Contributor
There was a problem hiding this comment.
This is going to be a very frequently hit operator facing error. Please add a long error message describing the problem when errno is ENOENT.
ripatel-fd
force-pushed
the
ripatel/snapshot-tiles
branch
from
10a9577 to
44ee4e5
Compare
mmcgee-jump
reviewed
May 3, 2025
| extern fd_topo_run_tile_t fd_tile_bencho; | ||
| extern fd_topo_run_tile_t fd_tile_benchg; | ||
| extern fd_topo_run_tile_t fd_tile_benchs; | ||
| extern fd_topo_run_tile_t fd_tile_snapshot_restore_FileRd; |
Contributor
There was a problem hiding this comment.
Can you just name these the same as everything else? Pick something 6 characters, so it can be the same name across everywhere (tile code, GUI, monitor, ...)
Contributor
Author
There was a problem hiding this comment.
Let's please do the hard part first (write the actual feature), you can rename them later
Contributor
There was a problem hiding this comment.
The hardest part is naming things :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.