-
Notifications
You must be signed in to change notification settings - Fork 373
Snapshot Loader 2.0 #4885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Snapshot Loader 2.0 #4885
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| $(call add-objs,fd_filerd_tile,fd_discof) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Snapshot Restore | ||
|
|
||
| ## Stream link conventions | ||
|
|
||
| Various snapshot components use byte streams, not packet streams. | ||
|
|
||
| These require custom conventions. | ||
|
|
||
| **Stream fragment descriptors** | ||
|
|
||
| Byte streams use `fd_frag_stream_meta_t` (defined in `fd_restore_base.h`). | ||
|
|
||
| These have the following changes: | ||
| - `chunk` is replaced by `goff` and `loff`, which are 64-bit offsets | ||
| describing the stream offset and dcache offset respectively | ||
| - `tsorig` / `tspub` are removed (latency is less relevant) | ||
| - `sig` is removed (cannot filter without looking at stream data) | ||
| - `sz` is widened to 32 bits. | ||
|
|
||
| `**Dcache allocations** | ||
|
|
||
| Payloads in stream dcaches are unaligned. Payloads are addressed with | ||
| uncompressed byte offsets relative to the workspace start. | ||
|
|
||
| (Compare this to the usual compact packet dcaches, which use 64 byte | ||
| aligned chunks with compressed addressing.) | ||
|
|
||
| **Stream backpressure** | ||
|
|
||
| Byte streams naturally require a reliable transport. | ||
|
|
||
| Consumers periodically publish their progress in `fseq`. | ||
| - `fseq[0]` is the lowest sequence number not yet consumed (standard) | ||
| - `fseq[1]` is the stream offset of the next byte not yet consumed | ||
| ` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just name these the same as everything else? Pick something 6 characters, so it can be the same name across everywhere (tile code, GUI, monitor, ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please do the hard part first (write the actual feature), you can rename them later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardest part is naming things :)