[BUILD] Standardize plugin paths and inject $ORIGIN rpath#497
Merged
zhzhcookie merged 5 commits intomainfrom Apr 9, 2026
Merged
[BUILD] Standardize plugin paths and inject $ORIGIN rpath#497zhzhcookie merged 5 commits intomainfrom
zhzhcookie merged 5 commits intomainfrom
Conversation
… iluvatar, and metax
Stardep-lmc
requested review from
Galaxy1458,
hxl0809,
i3wanna2,
menchunlei,
sgjzfzzf,
sunnycase and
zhzhcookie
as code owners
Stardep-lmc
force-pushed
the
fix-cmake-rpath-env
branch
from
679c0c6 to
92c29b9
Compare
zhzhcookie
changed the title
sgjzfzzf
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous CMake configuration used hardcoded absolute paths (e.g., ${Python3_SITELIB}) which caused ModuleNotFoundError in diverse environments like Conda or native Ubuntu. Additionally, the RPATH was lost during the pip install process.
Changes
Path Agnostic: Replaced hardcoded paths with $ENV{HOME}/.flagtree/ for mthreads, iluvatar, and metax.
RPATH Injection: Added CMAKE_BUILD_RPATH "$ORIGIN" in sub-directories and passed it to PARENT_SCOPE. This ensures the shared library can find its dependencies regardless of the installation directory.
Decoupling: Centralized the RPATH logic in backend-specific CMake files to keep the root CMakeLists.txt clean.