Skip to content

[BUILD] Standardize plugin paths and inject $ORIGIN rpath #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhzhcookie merged 5 commits into from
Apr 9, 2026
+35 −50
Merged

[BUILD] Standardize plugin paths and inject $ORIGIN rpath #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d350f1
fix(cmake): standardize plugin paths and inject $ORIGIN for mthreads,…
Stardep-lmc Apr 8, 2026
10bc098
fix(cmake)2.0
Stardep-lmc Apr 9, 2026
92c29b9
fix(cmake)3.0
Stardep-lmc Apr 9, 2026
441fb3b
Merge branch 'main' into fix-cmake-rpath-env
Stardep-lmc Apr 9, 2026
9590b4c
[BUILD] Fix build backend plugin on iluvatar, mthreads, metax
zhzhcookie Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ if(TRITON_BUILD_PYTHON_MODULE)
target_link_libraries(triton PRIVATE z)
endif()
target_link_options(triton PRIVATE ${LLVM_LDFLAGS})
set_target_properties(triton PROPERTIES
INSTALL_RPATH "$ORIGIN"
)
endif()

if (UNIX AND NOT APPLE)
Expand Down
33 changes: 11 additions & 22 deletions third_party/iluvatar/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ add_compile_options("-Wno-error=deprecated-declarations")

option(EDITABLE_MODE "Build in developer (editable) mode" OFF)
if(FLAGTREE_PLUGIN)
set(ILUVATAR_PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
set(PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
elseif(EDITABLE_MODE)
set(ILUVATAR_PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
set(PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
else()
set(ILUVATAR_PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
set(PLUGIN_DIR "$ENV{HOME}/.flagtree/iluvatar")
endif()
if(TRITON_BUILD_PYTHON_MODULE)
if(FLAGTREE_PLUGIN)
Expand All @@ -16,29 +16,18 @@ if(TRITON_BUILD_PYTHON_MODULE)
SHARED_LIB iluvatarTritonPlugin
)
else()
if(EDITABLE_MODE)
find_library(iluvatarTritonPluginLib
find_library(BackendTritonPluginLib
NAMES
iluvatarTritonPlugin.so
PATHS
${ILUVATAR_PLUGIN_DIR}
${PLUGIN_DIR}
REQUIRED
)
add_triton_plugin(TritonILUVATAR
SHARED_LIB ${iluvatarTritonPluginLib}
)
else()
find_library(iluvatarTritonPluginLib
NAMES
iluvatarTritonPlugin.so
PATHS
${ILUVATAR_PLUGIN_DIR}
REQUIRED
)
add_triton_plugin(TritonILUVATAR
SHARED_LIB ${iluvatarTritonPluginLib}
)
endif()
)
add_triton_plugin(TritonILUVATAR
SHARED_LIB ${BackendTritonPluginLib}
)
list(APPEND CMAKE_BUILD_RPATH "$ORIGIN")
set(CMAKE_BUILD_RPATH "${CMAKE_BUILD_RPATH}" PARENT_SCOPE)
endif()
endif()

Expand Down
14 changes: 8 additions & 6 deletions third_party/metax/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ add_subdirectory(lib)

option(EDITABLE_MODE "Build in developer (editable) mode" OFF)
if(FLAGTREE_PLUGIN)
set(METAX_PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
set(PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
elseif(EDITABLE_MODE)
set(METAX_PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
set(PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
else()
set(METAX_PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
set(PLUGIN_DIR "$ENV{HOME}/.flagtree/metax")
endif()
if(TRITON_BUILD_PYTHON_MODULE)
if(FLAGTREE_PLUGIN)
Expand All @@ -16,16 +16,18 @@ if(TRITON_BUILD_PYTHON_MODULE)
SHARED_LIB metaxTritonPlugin
)
else()
find_library(metaxTritonPluginLib
find_library(BackendTritonPluginLib
NAMES
metaxTritonPlugin.so
PATHS
${METAX_PLUGIN_DIR}
${PLUGIN_DIR}
REQUIRED
)
add_triton_plugin(TritonMetax
SHARED_LIB ${metaxTritonPluginLib}
SHARED_LIB ${BackendTritonPluginLib}
)
list(APPEND CMAKE_BUILD_RPATH "$ORIGIN")
set(CMAKE_BUILD_RPATH "${CMAKE_BUILD_RPATH}" PARENT_SCOPE)
endif()
endif()

Expand Down
35 changes: 13 additions & 22 deletions third_party/mthreads/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
add_subdirectory(include)
add_subdirectory(lib)

if(EDITABLE_MODE)
set(MTHREADS_PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
if(FLAGTREE_PLUGIN)
set(PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
elseif(EDITABLE_MODE)
set(PLUGIN_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
else()
set (MTHREADS_PLUGIN_DIR "${Python3_SITELIB}/triton/_C")
set(PLUGIN_DIR "$ENV{HOME}/.flagtree/mthreads")
endif()
if(TRITON_BUILD_PYTHON_MODULE)
if(FLAGTREE_PLUGIN)
Expand All @@ -13,29 +15,18 @@ if(TRITON_BUILD_PYTHON_MODULE)
SHARED_LIB mthreadsTritonPlugin
)
else()
if(EDITABLE_MODE)
find_library(mthreadsTritonPluginLib
find_library(BackendTritonPluginLib
NAMES
mthreadsTritonPlugin.so
PATHS
${CMAKE_CURRENT_SOURCE_DIR}
${PLUGIN_DIR}
REQUIRED
)
add_triton_plugin(TritonMTHREADS
SHARED_LIB ${mthreadsTritonPluginLib}
)
else()
find_library(mthreadsTritonPluginLib
NAMES
mthreadsTritonPlugin.so
PATHS
${MTHREADS_PLUGIN_DIR}
REQUIRED
)
add_triton_plugin(TritonMTHREADS
SHARED_LIB ${mthreadsTritonPluginLib}
)
endif()
)
add_triton_plugin(TritonMTHREADS
SHARED_LIB ${BackendTritonPluginLib}
)
list(APPEND CMAKE_BUILD_RPATH "$ORIGIN")
set(CMAKE_BUILD_RPATH "${CMAKE_BUILD_RPATH}" PARENT_SCOPE)
endif()
endif()

Expand Down
Loading