Skip to content

Conversation

@ABTastyAdel
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the segment hit tracking by converting all persona values to strings and includes a version bump to 4.2.1-beta. However, the PR introduces a critical bug in the default_strategy.dart file where JSON encoding results are not being assigned to variables.

Key Changes:

  • Converts persona map values to strings in the Segment hit's bodyTrack method to ensure proper serialization
  • Adds error handling for JSON encoding in the visitor exposure callback (though implementation is buggy)
  • Updates SDK version to 4.2.1-beta

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pubspec.yaml Bumps package version to 4.2.1-beta
lib/visitor/strategy/default_strategy.dart Adds try-catch for JSON encoding of exposure data, but fails to assign encoded values
lib/hits/segment.dart Converts persona values to strings and fixes typo in comment
lib/flagship_version.dart Updates version constant to 4.2.1-beta
example/lib/Providers/fs_data.dart Adds test context data with various types including an incorrect Null value
CHANGELOG.md Documents the persona string conversion fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.54%. Comparing base (3d766f5) to head (0b97909).
⚠️ Report is 3 commits behind head on 4.2.0-beta.

Files with missing lines Patch % Lines
lib/hits/segment.dart 0.00% 2 Missing ⚠️
lib/visitor/strategy/default_strategy.dart 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           4.2.0-beta      #58      +/-   ##
==============================================
- Coverage       77.60%   77.54%   -0.06%     
==============================================
  Files              67       67              
  Lines            2867     2864       -3     
==============================================
- Hits             2225     2221       -4     
- Misses            642      643       +1     
Files with missing lines Coverage Δ
lib/hits/segment.dart 0.00% <0.00%> (ø)
lib/visitor/strategy/default_strategy.dart 67.80% <66.66%> (+0.63%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d766f5...0b97909. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ABTastyAdel ABTastyAdel merged commit a56641d into 4.2.0-beta Nov 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants