Skip to content

fix segment hit #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ABTastyAdel merged 2 commits into from
Nov 20, 2025
Merged

fix segment hit #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caca619
fix segment hit
ABTastyAdel Nov 20, 2025
0b97909
fix segment hit
ABTastyAdel Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@

# 4.2.1-beta - 20/11/2025

- Converts all persona values to strings in segment tracking.

# 4.2.0-beta - 4/11/2025

Expand Down
7 changes: 6 additions & 1 deletion example/lib/Providers/fs_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ class UserData extends ChangeNotifier {
"testing_tracking_manager": true,
"isQA": true,
"fs_is_vip": true,
"condition1": "spécial"
"customer": "spécial",
"condition1": "segment",
"bucketKeyFlutter": "Mercredi",
"numericKeyFlutter": true,
"floatKeyFlutter": 12.5,
"nullKeyFlutter": Null
};
bool _hasConsented = true;
bool _isAuthenticated = false;
Expand Down
2 changes: 1 addition & 1 deletion lib/flagship_version.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/// This file is automatically updated
const FlagshipVersion = "4.2.0-beta";
const FlagshipVersion = "4.2.1-beta";
7 changes: 5 additions & 2 deletions lib/hits/segment.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ class Segment extends BaseHit {
@override
Map<String, Object> get bodyTrack {
var customBody = new Map<String, Object>();
customBody.addAll({"s": persona, "t": typeOfEvent});
// Add commun body
// Convert persona values to String
Map<String, String> personaString =
persona.map((key, value) => MapEntry(key, value.toString()));
customBody.addAll({"s": personaString, "t": typeOfEvent});
// Add common body
customBody.addAll(super.communBodyTrack);
return customBody;
}
Expand Down
13 changes: 8 additions & 5 deletions lib/visitor/strategy/default_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,15 @@ class DefaultStrategy implements IVisitor {
Flagship.logger(Level.INFO, " The campaign's flag already activated ");
return;
}

// When not duplicated
final String? flagJson =
exposedFlag != null ? jsonEncode(exposedFlag) : null;
final String? visitorJson =
exposedVisitor != null ? jsonEncode(exposedVisitor) : null;
String? flagJson = null;
String? visitorJson = null;
try {
exposedFlag != null ? jsonEncode(exposedFlag) : null;
exposedVisitor != null ? jsonEncode(exposedVisitor) : null;
} catch (e) {
Flagship.logger(Level.ERROR, "Error encoding exposure data: $e");
}

final activateHit = Activate(
modification,
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flagship
description: Flutter SDK for Flagship Feature management & Experiment platform for modern engineering and product teams
version: 4.2.0-beta
version: 4.2.1-beta
homepage: https://flagship.io

environment:
Expand Down