metrics: use Prometheus-standard le (less than or equal) labels #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates histogram metrics to use Prometheus-standard label naming conventions by switching from Histogram to PrometheusHistogram methods. This change ensures compatibility with Prometheus's standard le (less than or equal) labels for histogram buckets instead of custom bucket labels.
Key Changes
- Replaced
metrics.NewHistogramwithmetrics.NewPrometheusHistogramfor winning bid value tracking - Updated all
GetOrCreateHistogramcalls toGetOrCreatePrometheusHistogramfor bid values, relay latency, and milliseconds-into-slot metrics
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
faheelsattar
approved these changes
Dec 15, 2025
bharath-123
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875
If you've implemented the
mev_boost_winning_bid_valuemetric, this will be a breaking change, as the labels change. See #875 for more details.