Skip to content

metrics: use Prometheus-standard le (less than or equal) labels #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metachris merged 1 commit into from
Dec 15, 2025
Merged

metrics: use Prometheus-standard le (less than or equal) labels #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/VictoriaMetrics/metrics"
)

var winningBidValue = metrics.NewHistogram("mev_boost_winning_bid_value")
var winningBidValue = metrics.NewPrometheusHistogram("mev_boost_winning_bid_value")

const (
beaconNodeStatusLabel = `mev_boost_beacon_node_status_code_total{http_status_code="%s",endpoint="%s"}`
Expand All @@ -25,7 +25,7 @@ func IncrementBeaconNodeStatus(status, endpoint string) {

func RecordBidValue(relay string, value float64) {
l := fmt.Sprintf(bidValuesLabel, relay)
metrics.GetOrCreateHistogram(l).Update(value)
metrics.GetOrCreatePrometheusHistogram(l).Update(value)
}

func IncrementBidBelowMinBid(relay string) {
Expand All @@ -39,7 +39,7 @@ func RecordWinningBidValue(value float64) {

func RecordRelayLatency(endpoint, relay string, latency float64) {
l := fmt.Sprintf(relayLatencyLabel, endpoint, relay)
metrics.GetOrCreateHistogram(l).Update(latency)
metrics.GetOrCreatePrometheusHistogram(l).Update(latency)
}

func RecordRelayStatusCode(httpStatus, endpoint, relay string) {
Expand All @@ -54,5 +54,5 @@ func RecordRelayLastSlot(relay string, slot uint64) {

func RecordMsIntoSlot(endpoint string, ms float64) {
l := fmt.Sprintf(msIntoSlotLabel, endpoint)
metrics.GetOrCreateHistogram(l).Update(ms)
metrics.GetOrCreatePrometheusHistogram(l).Update(ms)
}
Loading