chore: bump version to v0.6.1 and exclude buggy apache-tvm-ffi releases#2347
chore: bump version to v0.6.1 and exclude buggy apache-tvm-ffi releases#2347
Conversation
- Update version.txt to v0.6.1 - Add dependency exclusions for apache-tvm-ffi v0.1.8 and v0.1.8.post0 Co-authored-by: Zihao Ye <yzh119@users.noreply.github.com>
📝 WalkthroughWalkthroughVersion 0.6.1 release with dependency constraint tightening. Apache-tvm-ffi versions 0.1.8 and 0.1.8.post0 are explicitly excluded from acceptable ranges in build configuration and requirements, while the version string is incremented from 0.6.0 to 0.6.1. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (3)📚 Learning: 2025-12-30T09:34:39.900ZApplied to files:
📚 Learning: 2025-12-30T09:34:39.900ZApplied to files:
📚 Learning: 2025-12-30T09:34:39.900ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine version increment for FlashInfer to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Wait for #2334 to be merged. |
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the version to v0.6.1 and updates the apache-tvm-ffi dependency to exclude buggy releases. The changes are consistent across pyproject.toml and requirements.txt. My review includes suggestions to improve maintainability by adding comments to the duplicated dependency specifications, which will help prevent them from becoming out of sync in the future.
|
|
||
| [build-system] | ||
| requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,<0.2"] | ||
| requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2"] |
There was a problem hiding this comment.
The dependency constraint for apache-tvm-ffi is duplicated here and in requirements.txt. This can lead to maintenance issues if they get out of sync. To mitigate this, consider making the requires list multi-line and adding a comment to remind developers to keep the versions synchronized. This improves readability and maintainability.
| requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2"] | |
| requires = [ | |
| "setuptools>=77", | |
| "packaging>=24", | |
| # The constraint below is also in requirements.txt and should be kept in sync | |
| "apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2", | |
| ] |
| @@ -1,4 +1,4 @@ | |||
| apache-tvm-ffi>=0.1.6,<0.2 | |||
| apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2 | |||
There was a problem hiding this comment.
To improve maintainability, it's good practice to add a comment here to note that this dependency constraint for apache-tvm-ffi is also defined in pyproject.toml under [build-system].requires. This helps prevent them from getting out of sync in the future.
# This constraint is also in pyproject.toml's [build-system] and should be kept in sync.
apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2
Code Review SummaryThis PR looks good overall! It properly addresses the apache-tvm-ffi dependency issue and follows the project's versioning scheme. Here's my detailed review: ✅ Strengths
📝 Minor Suggestions
🔍 Verification Checks✅ Version syntax is valid Security & PerformanceNo security or performance concerns. This is a pure dependency management change that prevents installation of known-buggy versions. Test CoverageThis type of change (version bump + dependency exclusion) doesn't require new tests. The existing test suite will validate that the allowed TVM-FFI versions work correctly. Recommendation: ✅ Approve with optional suggestion to update CHANGELOG.md The PR is ready to merge as-is. The CHANGELOG update is a nice-to-have but not blocking. |
Summary
This PR bumps the FlashInfer version to v0.6.1 and updates the apache-tvm-ffi dependency to exclude buggy releases.
Changes
version.txtto v0.6.1requirements.txtandpyproject.tomlFixes #2346
Generated with Claude Code
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.