Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ license-files = ["LICENSE", "LICENSE*.txt"]
flashinfer = "flashinfer.__main__:cli"

[build-system]
requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,<0.2"]
requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dependency constraint for apache-tvm-ffi is duplicated here and in requirements.txt. This can lead to maintenance issues if they get out of sync. To mitigate this, consider making the requires list multi-line and adding a comment to remind developers to keep the versions synchronized. This improves readability and maintainability.

Suggested change
requires = ["setuptools>=77", "packaging>=24", "apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2"]
requires = [
"setuptools>=77",
"packaging>=24",
# The constraint below is also in requirements.txt and should be kept in sync
"apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2",
]

build-backend = "build_backend"
backend-path = ["."]

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apache-tvm-ffi>=0.1.6,<0.2
apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's good practice to add a comment here to note that this dependency constraint for apache-tvm-ffi is also defined in pyproject.toml under [build-system].requires. This helps prevent them from getting out of sync in the future.

# This constraint is also in pyproject.toml's [build-system] and should be kept in sync.
apache-tvm-ffi>=0.1.6,!=0.1.8,!=0.1.8.post0,<0.2

click
einops
ninja
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.6.0
0.6.1