Android App Launcher Icon Improvements #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sébastien Delord <[email protected]>
Signed-off-by: Sébastien Delord <[email protected]>
Signed-off-by: Sébastien Delord <[email protected]>
Signed-off-by: Sébastien Delord <[email protected]>
Contributor
Author
|
Could someone with the appropriate building tools test these changes & tell me if they work? Thanks & have a good day. |
Member
|
@sebastien46 Yes! I will test this soon. Sorry I didn't get back to you. The rollout of v5 had me very occupied recently. |
Member
|
Finally got around to this. This is what it looks like. Screenshots
|
Member
|
Themed Icons doesn't work currently. |
Closed
Member
|
I'm sorry for the confusion. I didn't test this correctly. Tested again, now, and it works perfectly! Thank you 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1424
This adds support for a VectorDrawable version of the Android icon for TargetSDK 26 & up.
It also adds Themed / Monochrome for TargetSDK 33 & up.
I used the
logo.svgvector file present iniconsas reference for the VectorDrawable.I have no way of telling if this PR worked, since I don't have a Javascript development environment set up, only Android Studio.