patches: rename sqlite3-worker → sqlite3-dot-commands#13
Merged
Conversation
Upstream vercel-labs#190 (merged 2026-04-30, brought in via the just-bash@2.14.4 sync) fixed the worker bundling bug — published tarballs now ship dist/commands/sqlite3/worker.js, and there's an upstream regression test for the resolver. That half of the carry is no longer ours. The half we still carry is the dot-command preprocessor (commands/sqlite3/dot-commands.ts), which translates .tables, .schema, .mode, .read, .separator, .quit, etc. before handing the script to sql.js. Nothing equivalent exists upstream. - Rename the integration-test describe block and update its coverage to exercise the actual carry: SQL replacement (.tables, .schema), formatter mutation (.mode csv), and file inlining (.read). Drop the "ships the bundled worker" case — it's now testing upstream behavior. - Update the README patch table accordingly, with a parenthetical linking to vercel-labs#190 for history. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dce0892) fixed the bundled-worker shipping bug —findWorkerPath()is fixed, the tarball shipsdist/commands/sqlite3/worker.js, and there's even an upstream regression test (sqlite3.worker-resolution.test.ts). That half ofsqlite3-workeris no longer ours.packages/just-bash/src/commands/sqlite3/dot-commands.ts, 316 lines). It translates.tables,.schema,.mode,.read,.separator,.quit/.exit, etc. before the script reaches sql.js. Nothing equivalent exists upstream.sqlite3-worker→sqlite3-dot-commands) and refresh its coverage to exercise the real carry: SQL replacement (.tables,.schema), formatter mutation (.mode csv), file inlining (.read). Drop the"ships the bundled worker so basic SQL runs"case — it's now testing upstream behavior.No source-level functionality changes — only the patch-inventory documentation and the release-gating test surface.
Test plan
pnpm --filter just-bash exec vitest run src/flowglad-patches.integration.test.ts— 7/7 pass (4 sqlite3-dot-commands, 1 awk, 2 jq)🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.