Skip to content

[CQ] Unnecessary code cleanup #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 18, 2025

Addressed/removed unnecessary code in the form of:

  • redundant suppressions
  • redundant throws
  • redundant casts
  • unused imports
  • redundant toString(), substring(..) calls
  • unnecessary default branches
  • explicit types where <> will do
  • stream API call chains where toList() is enough

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from jwren April 18, 2025 02:16
@jwren jwren merged commit 5e5c861 into flutter:master Apr 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants