feat(framework): Enable timestamped logging by default#6727
Merged
danieljanes merged 3 commits intomainfrom Mar 9, 2026
Merged
feat(framework): Enable timestamped logging by default#6727danieljanes merged 3 commits intomainfrom
danieljanes merged 3 commits intomainfrom
Conversation
github-actions
bot
added
the
Maintainer
danieljanes
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Enables timestamped console logging by default in the Flower Python framework logger to provide more informative logs without requiring DEBUG level.
Changes:
- Set the default
ConsoleHandlerconfiguration to always include timestamps. - Update the
FLWR_LOG_LEVELenv-var configuration path to always keep timestamps enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
130
to
+135
| # Set log level via env var (show timestamps for `DEBUG`) | ||
| if log_level := os.getenv("FLWR_LOG_LEVEL"): | ||
| log_level = log_level.upper() | ||
| try: | ||
| is_debug = log_level == "DEBUG" | ||
| update_console_handler(level=log_level, timestamps=is_debug, colored=True) | ||
| update_console_handler(level=log_level, timestamps=True, colored=True) |
There was a problem hiding this comment.
The inline comment above this block says timestamps are shown for DEBUG, but this change makes timestamps always enabled (both by default and when FLWR_LOG_LEVEL is set). Update the comment (and consider dropping the now-redundant timestamps=True argument here) to match the new behavior and avoid confusion for future readers.
danieljanes
pushed a commit
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.