Skip to content

feat(framework): Enable timestamped logging by default #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljanes merged 3 commits into from
Mar 9, 2026
+2 −2
Merged

feat(framework): Enable timestamped logging by default #6727

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8db7d6
init
panh99 Mar 9, 2026
3480bbb
Merge branch 'main' into enable-ts
danieljanes Mar 9, 2026
6fa0820
Merge branch 'main' into enable-ts
flwrmachine Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/py/flwr/common/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def update_console_handler(

# Configure console logger
console_handler = ConsoleHandler(
timestamps=False,
timestamps=True,
json=False,
colored=True,
)
Expand All @@ -132,7 +132,7 @@ def update_console_handler(
log_level = log_level.upper()
try:
is_debug = log_level == "DEBUG"
update_console_handler(level=log_level, timestamps=is_debug, colored=True)
update_console_handler(level=log_level, timestamps=True, colored=True)
Comment on lines 130 to +135
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment above this block says timestamps are shown for DEBUG, but this change makes timestamps always enabled (both by default and when FLWR_LOG_LEVEL is set). Update the comment (and consider dropping the now-redundant timestamps=True argument here) to match the new behavior and avoid confusion for future readers.

Copilot uses AI. Check for mistakes.
if is_debug:
log(
WARN,
Expand Down
Loading