Skip to content

feat: expand brush style menu, fix inconsistencies - #1745

Open
Kneemund wants to merge 1 commit into
flxzt:mainfrom
Kneemund:feat/expand-brush-style-menu
Open

feat: expand brush style menu, fix inconsistencies#1745
Kneemund wants to merge 1 commit into
flxzt:mainfrom
Kneemund:feat/expand-brush-style-menu

Conversation

@Kneemund

@Kneemund Kneemund commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

There has been some discussion in #1602 on if the highlighter/marker brush style should be split off into a separate pen in the bottom sidebar. As I've explained there, I think that this is a compromise that makes the highlighter easily accessible while not duplicating parts of the UI and engine.

grafik

@JemmeCh

JemmeCh commented May 12, 2026

Copy link
Copy Markdown

Hello! I just started to use RNote and I was bumped out that there's no highligther tool. I spent the past 30mins reading about all the issues/merge requests you made and I think you found a good solution, especially this new UI design. It makes it easier to switch tools and removes convoluted submenues.

You mention in #1602 that your highlighter proposition adds an alpha value to the marker. In the spirit of this UI redesign, I think the seperation of the marker and the highlighter could be better since switching between highlighter mode and marker mode would be easier.

Maybe I'm missing how the actual switch would occur in practice... Would you be so kind to show us how it would work?

@Kneemund

Copy link
Copy Markdown
Collaborator Author

You mention in #1602 that your highlighter proposition adds an alpha value to the marker.

Hi, my set of PRs do not involve any alpha value modifications, the highlighter can use colors of any opacity. It uses multiplicative blending and also works with fully opaque colors.

Maybe I'm missing how the actual switch would occur in practice... Would you be so kind to show us how it would work?

Here is the demo of the workflow I propose.

  • I'm switching from the regular brush to the highlighter brush in the left sidebar, which also changes the stroke width (it is saved for every brush individually).
  • I'm using the default, fully opaque colors which I would also use with the regular brush.
highlighter-full.mp4

@JemmeCh

JemmeCh commented May 12, 2026

Copy link
Copy Markdown

You mention in #1602 that your highlighter proposition adds an alpha value to the marker.

Hi, my set of PRs do not involve any alpha value modifications, the highlighter can use colors of any opacity. It uses multiplicative blending and also works with fully opaque colors.

Maybe I'm missing how the actual switch would occur in practice... Would you be so kind to show us how it would work?

Here is the demo of the workflow I propose.

* I'm switching from the regular brush to the highlighter brush in the left sidebar, which also changes the stroke width (it is saved for every brush individually).

* I'm using the default, fully opaque colors which I would also use with the regular brush.

highlighter-full.mp4

Ahhhhhh ok I see! So the current Marker brush with description "Mark underneath other strokes" would be replaced by your implementation. Thank you for the clarification, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants