WIP: Handle keepalive missing events #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements an event-based tcp server for easier use. It is decoupled from the TCPSocket class to remove one layer of complexity. Also, the event-based approach allows interrupting this server as it won't be blocking inside an accept or recv call if not applicable.
- Updated documentation - Removed (unused) setSocketFD method
This reverts commit 2627d46.
This will disconnect the ReverseInterface when keepalive signals are missing. The problem with this implementation is that pausing the program on the robot will also trigger this.
|
In the back of my head I remember facing this problem in the past. So, this would be by intention that (missing) keepalive signal handling is not being done currently. |
|
Maybe a better approach would be to use the |
fmauch
force-pushed
the
tcp_server
branch
3 times, most recently
from
4a286db to
ed16661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disconnect the ReverseInterface when keepalive signals are missing.
The problem with this implementation is that pausing the program on the robot
will also trigger this.