Add const qualifiers and use std::move for improved const-correctness #4656
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request resolves several static analysis findings and improves code quality through
const-correctnessand move semantics.Static Analysis Findings (cppcheck)
include/fmt/args.h:60constVariableReference- Variable 'value' can be declared as reference to constinclude/fmt/chrono.h:512constParameterPointer- Parameter 'tm' can be declared as pointer to constinclude/fmt/chrono.h:523constVariablePointer- Variable 'tm' can be declared as pointer to constinclude/fmt/format.h:3945passedByValue- Function parameter 'decimal_point' should be passed by const referenceThis is my first pull request to this project. I've read CONTRIBUTING.md, all
ctestpass and code formattedclang*formatbut please let me know if anything needs adjustment. I'd be happy to help.Regards.