Skip to content

Add const qualifiers and use std::move for improved const-correctness #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaganCanSit wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

Add const qualifiers and use std::move for improved const-correctness #4656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/args.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class dynamic_arg_list {
public:
template <typename T, typename Arg> auto push(const Arg& arg) -> const T& {
auto new_node = std::unique_ptr<typed_node<T>>(new typed_node<T>(arg));
auto& value = new_node->value;
const auto& value = new_node->value;
new_node->next = std::move(head_);
head_ = std::move(new_node);
return value;
Expand Down
4 changes: 2 additions & 2 deletions include/fmt/chrono.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ inline auto gmtime(std::time_t time) -> std::tm {
return handle(gmtime_r(&time_, &tm_));
}

inline auto handle(std::tm* tm) -> bool { return tm != nullptr; }
inline auto handle(const std::tm* tm) -> bool { return tm != nullptr; }

inline auto handle(detail::null<>) -> bool {
using namespace fmt::detail;
Expand All @@ -520,7 +520,7 @@ inline auto gmtime(std::time_t time) -> std::tm {

#if !FMT_MSC_VERSION
inline auto fallback(detail::null<>) -> bool {
std::tm* tm = std::gmtime(&time_);
const std::tm* tm = std::gmtime(&time_);
if (tm) tm_ = *tm;
return tm != nullptr;
}
Expand Down
8 changes: 4 additions & 4 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,8 @@ template <typename OutputIt,
#if FMT_CLANG_VERSION >= 307 && !FMT_ICC_VERSION
__attribute__((no_sanitize("undefined")))
#endif
FMT_CONSTEXPR20 inline auto reserve(OutputIt it, size_t n) ->
typename OutputIt::value_type* {
FMT_CONSTEXPR20 inline auto
reserve(OutputIt it, size_t n) -> typename OutputIt::value_type* {
auto& c = get_container(it);
size_t size = c.size();
c.resize(size + n);
Expand Down Expand Up @@ -3944,8 +3944,8 @@ template <typename Locale> class format_facet : public Locale::facet {
explicit format_facet(string_view sep = "", std::string grouping = "\3",
std::string decimal_point = ".")
: separator_(sep.data(), sep.size()),
grouping_(grouping),
decimal_point_(decimal_point) {}
grouping_(std::move(grouping)),
decimal_point_(std::move(decimal_point)) {}

auto put(appender out, loc_value val, const format_specs& specs) const
-> bool {
Expand Down