Conversation
There was a problem hiding this comment.
Pull request overview
Moves the parsed-argument summary printing utility from Command onto ParseResult, making it callable directly on parse results (and updating examples accordingly).
Changes:
- Added
ParseResult.print_summary()(with recursive subcommand printing). - Removed
Command.print_summary(result). - Updated example CLIs to call
result.print_summary().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/argmojo/parse_result.mojo | Adds print_summary() implementation on ParseResult, including subcommand recursion and unknown-args display. |
| src/argmojo/command.mojo | Removes the Command.print_summary() helper. |
| examples/mgrep.mojo | Updates example to call result.print_summary(). |
| examples/mgit.mojo | Updates example to call result.print_summary(). |
| examples/demo.mojo | Updates example to call result.print_summary(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the parsed-argument summary printing utility from
CommandontoParseResult, making it callable directly on parse results (and updating examples accordingly).Changes:
ParseResult.print_summary()(with recursive subcommand printing).Command.print_summary(result).result.print_summary().