Conversation
Add confirmation_option() and confirmation_option["prompt"]() builder methods on Command. When enabled, auto-registers --yes/-y flag and prompts the user for confirmation after parsing. Passing --yes or -y skips the prompt. Aborts on decline or non-interactive stdin. Equivalent to Click's confirmation_option decorator. - 13 new tests in tests/test_confirmation.mojo - Update user manual, changelog, planning doc - 526 tests across 18 files, all passing
There was a problem hiding this comment.
Pull request overview
Adds a Click-style confirmation prompt feature to ArgMojo commands, enabling destructive commands to require an explicit interactive confirmation unless the user passes --yes/-y.
Changes:
- Implement
Command.confirmation_option()andCommand.confirmation_option["prompt"]()plus a post-parse_confirm()step. - Add a new test suite covering confirmation behavior and integrate it into the test task.
- Document the new feature in the user manual and changelog/planning docs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/argmojo/command.mojo |
Adds confirmation-related fields, builder methods, and a _confirm() hook into parse_arguments(). |
tests/test_confirmation.mojo |
Introduces tests for --yes/-y skipping and non-interactive abort behavior, plus integration scenarios (subcommands/parents/prompt). |
pixi.toml |
Adds the new confirmation tests to the pixi run test pipeline (run with stdin redirected). |
docs/user_manual.md |
Documents confirmation option usage, API references, and examples. |
docs/changelog.md |
Notes the new confirmation option feature in unreleased changes. |
docs/argmojo_overall_planning.md |
Marks confirmation as complete and updates the test/docs feature matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds confirmation_option() and confirmation_option"prompt" builder methods on Command. When enabled, auto-registers --yes/-y flag and prompts the user for confirmation after parsing. Passing --yes or -y skips the prompt. Aborts on decline or non-interactive stdin.
Changes:
Command.confirmation_option()andCommand.confirmation_option["prompt"]()plus a post-parse_confirm()step.