Fix on av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1] when AV pair is absent#2197
Open
kost wants to merge 1 commit into
Open
Fix on av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1] when AV pair is absent#2197kost wants to merge 1 commit into
kost wants to merge 1 commit into
Conversation
Contributor
|
Just out of curiousity: Where did you run into a host that does not populate the |
Collaborator
|
Hi @kost, I had the same question while trying to validate this PR: in which target/protocol/server configuration did you see I tested against Windows DC services and Samba, and they all populated it, so any repro details would help. |
alexisbalbachan
added
the
waiting for response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeResponseNTLMv2 crashed on av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1] when that AV pair is absent
Now falls back to the NetBIOS computer name (NTLMSSP_AV_HOSTNAME), then to empty