Skip to content

Fix on av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1] when AV pair is absent #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kost wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix on av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1] when AV pair is absent #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion impacket/ntlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,12 @@ def computeResponseNTLMv2(flags, serverChallenge, clientChallenge, serverName, d
# This is set at Local Security Policy -> Local Policies -> Security Options -> Server SPN target name validation
# level
if TEST_CASE is False:
av_pairs[NTLMSSP_AV_TARGET_NAME] = f"{service}/".encode('utf-16le') + av_pairs[NTLMSSP_AV_DNS_HOSTNAME][1]
# The DNS computer name AV pair is optional (e.g. servers reached by IP
# may omit it); fall back to the NetBIOS computer name, then to no host,
# instead of crashing on a missing pair.
hostAv = av_pairs[NTLMSSP_AV_DNS_HOSTNAME] or av_pairs[NTLMSSP_AV_HOSTNAME]
hostName = hostAv[1] if hostAv is not None else b''
av_pairs[NTLMSSP_AV_TARGET_NAME] = f"{service}/".encode('utf-16le') + hostName
if av_pairs[NTLMSSP_AV_TIME] is not None:
aTime = av_pairs[NTLMSSP_AV_TIME][1]
else:
Expand Down