arcv: Fix arcv.vclr intrinsic signature.#206
Open
luismgsilva wants to merge 2 commits into
Open
Conversation
luismgsilva
force-pushed
the
luis/fix-vclr
branch
5 times, most recently
from
ea81b05 to
5ff7742
Compare
luismgsilva
changed the title
luismgsilva
force-pushed
the
luis/fix-vclr
branch
6 times, most recently
from
ec063e0 to
5d8bcac
Compare
MichielDerhaeg
requested changes
Feb 10, 2026
luismgsilva
force-pushed
the
luis/fix-vclr
branch
2 times, most recently
from
4d1590f to
7ddd54f
Compare
added 2 commits
February 12, 2026 02:03
According to the XARCV 1.8 specification, he arcv.vclr instruction takes (imm, vl) in the base variant and (vector, imm, vl) for tail-undisturbed. Test case updated to remove the vector input in base variant, remove mask intrinsic and add tail-undisturbed. Signed-off-by: Luis Silva <luiss@synopsys.com>
arcv_vclr clears the lower imm[4:0] number of elements of vd. However, the current pattern uses imm5_operand, which only accepts values < 5 and therefore rejects valid immediates. The instruction encoding allows a 5-bit unsigned immediate, i.e. values in the range 0..31. Introduce a dedicated const_0_31_operand predicate and use it for arcv_vclr. Signed-off-by: Luis Silva <luiss@synopsys.com>
luismgsilva
force-pushed
the
luis/fix-vclr
branch
from
7ddd54f to
6afd0d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arcv.vclr instruction takes (imm, vl) in the base variant and
(vector, imm, vl) for tail-undisturbed. We add a custom shape and
expand method to handle both cases.