fix: Refactored badge message provider#1412
fix: Refactored badge message provider#1412mariobehling merged 26 commits intofossasia:developmentfrom
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @nope3472, you have reached your weekly rate limit for Sourcery. Please try again later
|
@samruddhi-Rahegaonkar once the mapping_fix pr gets merged then i will update this branch |
|
@nope3472 Resolve conficts Please. |
|
@nope3472 The PR has already get mereged Please do the needful. |
Build StatusBuild successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/17556283293/artifacts/3955547105. ScreenshotsAndroid Screenshots
iPhone Screenshots
iPad Screenshots
|
||||||||||||||||||||||||
-1_home_screen.png?raw=true)
-2_text_badge.png?raw=true){kind=icon}
-3_emoji_badge.png?raw=true){kind=icon}
-4_inverted_emoji_badge.png?raw=true){kind=icon}
-5_saved_badges.png?raw=true)
-6_saved_badges_clicked.png?raw=true)
-7_draw_badge.png?raw=true){kind=icon}
|
hey @mariobehling @hpdang i think we can go ahead with this pr |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
mariobehling
left a comment
mariobehling
left a comment
There was a problem hiding this comment.
Please resolve conflicts.
Co-authored-by: Mario Behling <mb@mariobehling.de>
|
@hpdang updated the branch |
|
@nope3472 still showing branch is out of date |
|
@hpdang i have again updated the branch |
|
I'm wondering if this is the right way to solve the issue pointed out in #1399. #1399 states that the file has grown too large. However, this PR just exports each function into a separate file, and that file is also similar in length. What if we instead created several small files, all inside a separate subdirectory for each animation type? |
@CloudyPadmal I do agree with it. |
…to refactorbadgemessageprovider
|
hey @CloudyPadmal thanks for the suggestion i have made the requested changes |
|
@mariobehling @hpdang @samruddhi-Rahegaonkar i think we can go with this one |
|
@CloudyPadmal could you please help to check this? |
|
@hpdang Looks good to me! |
…e3472/badgemagic-app into refactorbadgemessageprovider
|
@mariobehling i have resolved the conflicts here also |
7 participants
Fixes #1399
Changes
-Refactored BadgeMessageProvider to keep the file clean and focused
Screenshots / Recordings
Checklist:
constants.dartwithout hard coding any value.